Fix VariableToolTip auto resizing.
ClosedPublic

Authored by michalsrb on Aug 16 2018, 2:19 PM.

Details

Summary

The VariableToolTip is supposed to resize vertically as much as can fit
in the window whenever the content changes. It was not working because
the m_itemHeight was 0 which was because the QTreeView::indexRowSizeHint
was called with index from m_model instead of m_proxy.

Same for the initial selection below.

Test Plan

Debug some program, stop execution and hover over some variable. Expand
some subitems - the tooltip should be resizing.

Diff Detail

Repository
R32 KDevelop
Branch
fix-variabletooltip-expansion (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1914
Build 1932: arc lint + arc unit
michalsrb created this revision.Aug 16 2018, 2:19 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 16 2018, 2:19 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
michalsrb requested review of this revision.Aug 16 2018, 2:19 PM
kfunk accepted this revision.Aug 16 2018, 2:36 PM
kfunk added a subscriber: kfunk.

Looks sensible to me. Do you permissions to push? If so, to 5.2 branch ideally.

This revision is now accepted and ready to land.Aug 16 2018, 2:36 PM

I don't have permissions to push. Someone else please do it.

This comment was removed by shubham.
This revision was automatically updated to reflect the committed changes.
brauch added a subscriber: brauch.Aug 16 2018, 3:21 PM

The patches you submitted recently are all very nice, if you feel think you are going to contribute more things in the future, I'm sure we can give you the permission bit to write to the KDE repos yourself :)
Just let us know at any time if you want that.

shubham removed a subscriber: shubham.Aug 16 2018, 3:24 PM
apol added a subscriber: apol.Aug 19 2018, 10:16 AM

The patches you submitted recently are all very nice, if you feel think you are going to contribute more things in the future, I'm sure we can give you the permission bit to write to the KDE repos yourself :)
Just let us know at any time if you want that.

https://community.kde.org/Infrastructure/Get_a_Developer_Account