Explicitly request TagAttribute in Akonadi Monitor's tag fetch scope
ClosedPublic

Authored by dvratil on Aug 16 2018, 1:17 PM.

Details

Summary

Akonadi errornously returns all Tag attributes by default when queried
via TagFetchJob, which Akonadi Monitor used to do internally. This has
changed in the recent Notification Payload feature when the Tag is sent
directly as part of the change notification. This uses a slightly different
code path on the serve to assemble the Tag as part of the tag change
notification. This code path honors the TagFetchScope settings and only
returns tags that were explicitly requested, thus breaking your test,
which did not ask for the attribute explicitly.

Test Plan

Fixes akonadistoragetest

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil requested review of this revision.Aug 16 2018, 1:17 PM
dvratil created this revision.
ervin accepted this revision.Aug 16 2018, 3:36 PM

Thanks a lot Dan!

This revision is now accepted and ready to land.Aug 16 2018, 3:36 PM
This revision was automatically updated to reflect the committed changes.