| brauch |
This should solve long standing bugs that make kdev-php difficult
to use with common PHP frameworks.
BUG: 241750
BUG: 295866
FIXED-IN: 5.3.0
| No Linters Available |
| No Unit Test Coverage |
| Buildable 1910 | |
| Build 1928: arc lint + arc unit |
Maybe you make the the visitAssignment code a bit more readable by breaking it up into 2-3 functions?
If you tend to the inline notes, this does not look too wrong ...
| duchain/builders/declarationbuilder.cpp | ||
|---|---|---|
| 1197 | move this down below the next condition, it doesn't need it | |
| 1215 | I don't think you are allowed to unlock the lock here, you are still using the items below ... but in the builder code, stuff like this usually works because you have the parse lock in addition, so no idea. | |
| 1226 | replace by: DUChainWriteLocker wlock; | |
| 1228 | remove this, it's unlocked automatically here anyways | |
| 1248 | as above | |
| 1270 | remove | |
Splitting some code out into a separate function is a bit more tricky than I thought. I have prototype code for it, but it just doesn't quite work right (unit tests don't pass :( ).
I'll merge it for now the way it is and have a look at the refactored version after.