Inject environment profile variables into debug process environment.
ClosedPublic

Authored by Kebianizao on Aug 15 2018, 11:00 PM.

Details

Summary

Extends DebugJob and DebugSession classes including launch configuration environment variables.

The approach taken is getting the environment profile name within the debug process, storing it in the debug job and injecting the environment variables in the debuggee just before it is launched

BUG: 322477

Diff Detail

Repository
R53 KDevelop: Python Support
Branch
raul (branched from 5.2)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1889
Build 1907: arc lint + arc unit
Kebianizao requested review of this revision.Aug 15 2018, 11:00 PM
Kebianizao created this revision.
Kebianizao retitled this revision from Summary: Inject environment profile variables into debug process environment. The approach taken is getting the environment profile name within the debug process, storing it in the debug job and injecting the environment variables in the debuggee... to Inject environment profile variables into debug process environment..Aug 15 2018, 11:03 PM
Kebianizao edited the summary of this revision. (Show Details)
brauch accepted this revision.Aug 16 2018, 6:45 AM
brauch added a subscriber: brauch.

This change looks very reasonable to me. Thank you!

Can you submit this yourself, or should I do it for you?

This revision is now accepted and ready to land.Aug 16 2018, 6:45 AM

Thanks for the review.
To be honest I'm not sure how could I submit this patch. If you mean submitting to the mailing list, I can do, but I think it's already there, as phabricator is linked to kdevelop-devel. If you mean pushing to the repository, I'm not aware that I've been granted push permission.
Also, take into account that the patched is based on 5.2 branch as I run latest stable kdevelop (5.2.3), I haven't tested this on either kdev-python or kdevelop master branches.

No, you need special karma to push to the KDE repos. If you are not aware you have this, you have not ;)
I will submit this for you later.

brauch closed this revision.Aug 16 2018, 12:18 PM

Of course arc is too stupid for the special characters in your name, sorry about that ...