- Slightly improve readability;
- Check that offset and location have been passed;
- Sanitize slide in/out duration (if any of those is equal to 0, KWin will crash).
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:4a775dd485d8: [effects/slidingpopups] Overhaul slotPropertyNotify
- Launched Yakuake;
- Pressed F12 several times (Yakuake still slides in/out).
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think that's the last patch.
Code of the sliding popups effect is now in much better shape.
| effects/slidingpopups/slidingpopups.cpp | ||
|---|---|---|
| 325 | what's the rationale behind this cap value? | |
| effects/slidingpopups/slidingpopups.cpp | ||
|---|---|---|
| 325 | If I understand your question correctly, you ask why we don't allow to use "0" as a duration? TimeLine will later divide the number number of elapsed milliseconds by this duration (d->elapsed / d->duration), so we have to prevent division by 0. Also, maybe, in this case, we could do something similar to what we do in reconfigure(), e.g. animData.slideInDuration = (animData.slideInDuration().count() != 0) ? animData.slideInDuration : m_slideInDuration; | |