remove highlighting download dialog

Authored by cullmann on Aug 14 2018, 12:30 PM.




  1. there is one frameworks release per month that already provides a stream of hl updates
  2. often new highlightings anyways need a new frameworks version
  3. one can easily update only a part of the files which leads to broken other highlighting that include parts of them
  4. the updates might easily break the non-downloadable indenters

GUI: highlighting download dialog removed

Test Plan

make test

Diff Detail

R39 KTextEditor
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Aug 14 2018, 12:30 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 14 2018, 12:30 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Aug 14 2018, 12:30 PM
dhaumann accepted this revision.Aug 14 2018, 12:43 PM

Looks good. But along with this change, please change the docbook in kate.git:

We have doc/katepart/configuring.docbook

<term><guibutton>Download Highlighting Files...</guibutton></term>
      Click this button to download new or updated syntax highlight descriptions
      from the &kappname; website.

And we have: doc/katepart/development.docbook

  <para>You can download updated or additional syntax highlight definitions from the &kappname; website by clicking the
  <guibutton>Download Highlighting Files...</guibutton> button in the <link linkend="pref-open-save-modes-filetypes">Modes &amp; Filetypes</link> tab of the <link linkend="config-dialog">Config Dialog</link>.</para>
This revision is now accepted and ready to land.Aug 14 2018, 12:43 PM
This revision was automatically updated to reflect the committed changes.
rjvbb added a subscriber: rjvbb.Aug 14 2018, 5:55 PM

Downloading already didn't work for me since quite a while (the operation never completed) but what does this mean for highlighting files I write myself (or someone's mom does)?

Other users who do not follow the latest development releases [...] are likely not the target audience for downloading highlighting files.

I take a bit exception with this; users of certain distributions that aim to allow them to work *with* the software instead of *on* (as in applying updates) are being compared with a rather negative and probably sexist view of their mother. The opposite is true for many such users: working with stable releases means you have more reason to update things like highlighting files.

FWIW, there was never a reason to have a download/update button in the "userland" configure UI; a KCM provided by the highlighting framework would make perfect sense (that same KCM could serve to disable/uninstall useless highlighting files; your mom probably doesn't need more than half the ones that get installed.

Independent of mom/dad/somebody else, for highlighting files you create on your own, you just can perfectly add them to the local directories as specified in the manual.
If you really want to have new highlighting files and risk that stuff like indenters or included stuff might break, you can still get them from the syntax-highlighting git and put them in that folders manually, too.
The only thing that is no longer there is the "auto" download dialog.