| davidedmundson |
| Plasma |
If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
is necessary.
I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
even if it's a bug we'll have to workaround it.
BUG: 397338
I have favorites in kickoff again.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| shell/scripting/applet.cpp | ||
|---|---|---|
| 139 | So writeEntry gets QJSValue& now why you call again toVariant(), here everywhere else. | |
| shell/scripting/applet.cpp | ||
|---|---|---|
| 139 | KConfigGroup != ConfigGroup. d->configGroup is from kconfig and does not take QJSValue. That's the core of the bugfix. | |
A different approach of fixing this is to do something like
if(value.userType() == qMetaTypeId<QJSValue>())
value = value.value<QJSValue>().toVariant();in every function for every QVariant parameter. Advantages are that it's more obvious and the function's interface does not change.
Disadvantages are that it has more overhead and more lines of code.
| shell/scripting/applet.h | ||
|---|---|---|
| 70–73 | maybe it needs to return a QJSValue as well then? | |
| shell/scripting/applet.h | ||
|---|---|---|
| 70–73 | No, that works fine. My theory is that it works because as a QVariant<QJSValue> can still be converted to QString, int etc. | |