Differential D14811

Remove attachmentservicemenu in favor of Purpose plugin
ClosedPublic
Actions

Authored by nicolasfella on Aug 13 2018, 9:41 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail
Commits
R206:bae4ef916c87: Remove attachmentservicemenu in favor of Purpose plugin
Summary

Since 5.48 Purpose has a FileItemActionPlugin that adds a "Send via Mail" action to Dolphin et al. It offers all the functionality of the KMail implementation, but respects the users prefered Email program. KDE Connect and BlueDevil dropped their custom actions in favor of Purpose plugins, too.

Test Plan

"Send as Email Attachment" action no longer appears in Dolphin. Can still send emails via "Share->Send via Email"

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Aug 13 2018, 9:41 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 13 2018, 9:41 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
nicolasfella requested review of this revision.Aug 13 2018, 9:41 PM
mlaurent accepted this revision.Aug 14 2018, 5:16 AM
This revision is now accepted and ready to land.Aug 14 2018, 5:16 AM
Closed by commit R206:bae4ef916c87: Remove attachmentservicemenu in favor of Purpose plugin (authored by nicolasfella). · Explain WhyAug 15 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39794

View Options

src/CMakeLists.txt

Loading...
View Options

src/data/kmail_addattachmentservicemenu.desktop

Loading...