The return code of the Pool::load() method is somewhat misleading, as it
returns true only if there were no errors at all. The error flag is set on the first
validation error, but the pool will contain meaningful data nevertheless.
BUG: 397531
Details
Details
- Reviewers
apol - Group Reviewers
Plasma Frameworks - Commits
- R120:0ec3f76810b7: [AppStream Runner] Also search when there were errors during Pool::load
Searching for "blend"
Unfixed version:
No results are returned under "Software Center"
Fixed version:
Software Center: "Get Blender", "Get Hugin", ...
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This is outright weird, please send just one patch with the feature and the logging and without the wrong lines.
Comment Actions
Which wrong lines?
Why should I squash the commits? Each one:
- compiles and works on its own
- addresses a slightly different issue
Comment Actions
Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets
OTOH, commits should be preferably "atomic" - not splittable. That means that every bugfix, feature, refactoring or reformatting should go into an own commit. This, too, improves the readability of the history.
Comment Actions
Ugh, like I said, can you please squash them into a commit?
They are good changes in general.
Comment Actions
As I said, that violates https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets and I prefer to keep these apart.
This one fixes the behaviour, and has a separate bug report.
The other ones change logging and are quite independent.