kioslave/Mac : proxy the bundle-exec and make an agent
Needs ReviewPublic

Authored by rjvbb on Aug 13 2018, 4:46 PM.
This revision needs review, but there are no reviewers specified.



(I thought I had committed this already...)

On Mac, kioslave must be built as an app bundle to prevent keyboard input issues (for instance during the authentication step with kio-gdrive) but it must also be found in the expected location and, ideally, not put up a menu bar nor appear in the app switcher.

This patch achieves all that:

  • installs a wrapper script that proxies the kioslave app bundle-exec
  • adds the CoreFoundation magic code that instructs the application to behave as an agent.
Test Plan

Works as intended with all kioslaves I tested.

Alternatively one could use a Mac-specific hard-codec path to launch the bundle-exec instead of installing the wrapper script. That would require patching klauncher - and I don't know if this the only place where kioslave is started.

Diff Detail

Lint Skipped
Unit Tests Skipped
Build Status
Buildable 1787
Build 1805: arc lint + arc unit
rjvbb requested review of this revision.Aug 13 2018, 4:46 PM
rjvbb created this revision.
rjvbb updated this revision to Diff 39623.Aug 13 2018, 4:48 PM

Use a current instead of an obsolete platform token.

rjvbb set the repository for this revision to R241 KIO.Aug 13 2018, 4:49 PM