Differential D14798

Scope the glib hack to older Qt versions
ClosedPublic
Actions

Authored by svuorela on Aug 13 2018, 4:24 PM.

Details

Reviewers
sandsmark
ahartmetz
dfaure
Group Reviewers
Konsole
Commits
R319:2c9cbdd1d0ac: Scope the glib hack to only < Qt5.11.2 versions
R319:b2c8322a461b: Scope the glib hack to only < Qt5.11.2 versions
Summary

Qt bug is now fixed. don't hack around it.

Test Plan

Code builds

Diff Detail

Repository
R319 Konsole
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1782
Build 1800: arc lint + arc unit
svuorela created this revision.Aug 13 2018, 4:24 PM
Restricted Application added a project: Konsole. · View Herald TranscriptAug 13 2018, 4:24 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
svuorela requested review of this revision.Aug 13 2018, 4:24 PM
dfaure accepted this revision.Aug 14 2018, 9:07 AM

(I'd normally add spaces after commas in QT_VERSION_CHECK)

This revision is now accepted and ready to land.Aug 14 2018, 9:07 AM
cfeck added a subscriber: cfeck.Aug 19 2018, 1:54 AM

Is this a compile-time or runtime version check?

hindenburg added a comment.Aug 21 2018, 2:47 AM
In D14798#311336, @cfeck wrote:

Is this a compile-time or runtime version check?

#if are pre-processor, so compile time

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (4 lines)

Diff 39617

View Options

src/main.cpp

Loading...