I have an update pending for kdev-php's internal data file,
which would bring it above the 5MB size limit. This code
adds an exception for files inside kdev* related data dirs,
so that the limit doesn't apply for those.
Details
Details
- Reviewers
brauch - Commits
- R32:56bca5044e16: Ignore file size limit for internal data files.
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Branch
- filelimit
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1768 Build 1786: arc lint + arc unit
| kdevplatform/language/backgroundparser/parsejob.cpp | ||
|---|---|---|
| 279 | I think you need to compare two canonical paths here, not this. This will break if there are symlinks in the path(s), or something changes about leading or trailing slashes, or e.g. when the user configures his XDG_DATA_DIRS with ../ segments in it or whatever ... | |
Comment Actions
Now I would compute the fileInfo's canonicalPath only once (it might require a stat) and then this looks okay :)
I can't accept it apparently because the discussion is still open ...