Differential D14780

Fix Julia backend build for Julia minor version > 5
AbandonedPublic
Actions

Authored by filipesaraiva on Aug 13 2018, 9:01 AM.

Details

Reviewers
asemke
sirgienko
Group Reviewers
Cantor
Summary

My system has julia 0.6.4 installed. I could not compile julia backend and my Qt Creator was informing me "no matching function for call 'jl_string_ptr'".

So, after I applied the current change, I could compile the backend correctly and run the backend.

Test Plan
  • Apply the patch;
  • Compile Julia backend with julia minor version > 5
  • Try to run a few commands in Julia backend at Cantor.

Diff Detail

Repository
R55 Cantor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1757
Build 1775: arc lint + arc unit
filipesaraiva created this revision.Aug 13 2018, 9:01 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 13 2018, 9:01 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
filipesaraiva requested review of this revision.Aug 13 2018, 9:01 AM
filipesaraiva edited the summary of this revision. (Show Details)Aug 13 2018, 9:06 AM
filipesaraiva edited the test plan for this revision. (Show Details)
filipesaraiva added reviewers: Cantor, asemke.
filipesaraiva added a project: Cantor.
filipesaraiva added a reviewer: sirgienko.
asemke added a comment.Aug 13 2018, 9:51 AM

There is no jl_string_ptr in Julia 0.4.7. Are you using older includes with newer libraries?

filipesaraiva added a comment.Aug 13 2018, 10:11 AM
In D14780#307590, @asemke wrote:

There is no jl_string_ptr in Julia 0.4.7. Are you using older includes with newer libraries?

Maybe it is a very old piece of code. I am using 0.6.4 version. Before my change, the code was using jl_string_ptr if minor version > 5, but this function doesn't exist for that version. Which version are you using?

sirgienko added a comment.EditedAug 13 2018, 4:37 PM
In D14780#307604, @filipesaraiva wrote:
In D14780#307590, @asemke wrote:

There is no jl_string_ptr in Julia 0.4.7. Are you using older includes with newer libraries?

Maybe it is a very old piece of code. I am using 0.6.4 version. Before my change, the code was using jl_string_ptr if minor version > 5, but this function doesn't exist for that version. Which version are you using?

Hi @filipesaraiva, it's very interesting, because I test this code with Julia 0.6.3 and in dev files (julia.h:1207) I have this function:
JL_DLLEXPORT const char *jl_string_ptr(jl_value_t *s);
I also check v0.7.0 and this version also have this function (julia.h:1310)

sirgienko added a comment.EditedAug 13 2018, 4:53 PM

@filipesaraiva, after 90b001d1b01556cc5d5b60791e9b43e6dfcff0b4, do you still have build errors?

filipesaraiva abandoned this revision.Aug 14 2018, 9:30 AM
In D14780#308005, @sirgienko wrote:

@filipesaraiva, after 90b001d1b01556cc5d5b60791e9b43e6dfcff0b4, do you still have build errors?

That is working now.

Well, next time if someone is working (and discussing) in something, it is a good practice to let that person finnish the work before push something related to that.

Revision Contents
Changeset List

Diff 39565

View Options

src/backends/julia/juliaserver/juliaserver.cpp

Loading...