Differential D14761

quickopen: optimize: remove model from SortFilter proxy model during populate
ClosedPublic
Actions

Authored by brauch on Aug 12 2018, 11:33 AM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R40:90f51f5830e3: quickopen: optimize: remove model from SortFilter proxy model during populate
Summary
Before, it would update its internal mapping after inserting each and
every item, making opening the quickopen widget rather slow for
projects containing lots of files.
Setting dynamicSortFilter to false also does not seem to work with
QStandardItemModel, not quite sure why.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
brauch created this revision.Aug 12 2018, 11:33 AM
Restricted Application added a project: Kate. · View Herald TranscriptAug 12 2018, 11:33 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
brauch requested review of this revision.Aug 12 2018, 11:33 AM
cullmann accepted this revision.Aug 12 2018, 11:46 AM
cullmann added a subscriber: cullmann.

This should not hurt ;=)

This revision is now accepted and ready to land.Aug 12 2018, 11:46 AM
dhaumann added a subscriber: dhaumann.Aug 13 2018, 5:39 AM

Nice patch. Please add a comment:
// Temporarily remove source model to avoid triggering unnecessary internal updates all the time

Closed by commit R40:90f51f5830e3: quickopen: optimize: remove model from SortFilter proxy model during populate (authored by brauch). · Explain WhyAug 13 2018, 8:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkate/katequickopen.cpp (3 lines)

Diff 39510

View Options

kate/katequickopen.cpp

Loading...