Differential D14744

Make Definition::isDelimiter() also work for invalid definitions
ClosedPublic
Actions

Authored by dhaumann on Aug 11 2018, 1:16 PM.

Details

Reviewers
cullmann
vkrause
Commits
R216:eef5bce7080f: Make Definition::isDelimiter() also work for invalid definitions
Summary

Used by KTextEditor.

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Aug 11 2018, 1:16 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 11 2018, 1:16 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Aug 11 2018, 1:16 PM
cullmann accepted this revision.Aug 11 2018, 1:17 PM

Avoids to have that workaround on the user side.
Actually I think we want that, too, for things like "formats", that you always have some default normal format.
But that is a different issue.

This revision is now accepted and ready to land.Aug 11 2018, 1:17 PM
vkrause accepted this revision.Aug 11 2018, 7:33 PM
dhaumann updated this revision to Diff 39470.Aug 11 2018, 7:51 PM
  • Add support for getters of invalid Definitions
vkrause accepted this revision.Aug 11 2018, 7:57 PM
Closed by commit R216:eef5bce7080f: Make Definition::isDelimiter() also work for invalid definitions (authored by dhaumann). · Explain WhyAug 11 2018, 7:58 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 39472