Differential D14717

Implement fill event
ClosedPublic
Actions

Authored by mlaurent on Aug 10 2018, 5:57 AM.

Tags

Subscribers

Details

Reviewers

Commits

R1003:b96ef6b724bb: Implement fill event

Summary

We need to implement ReservationFor<RentalCar> too (but I don't have idea how :) )

Diff Detail

Repository

R1003 KItinerary: Travel Reservation handling library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent created this revision.Aug 10 2018, 5:57 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 10 2018, 5:57 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

mlaurent requested review of this revision.Aug 10 2018, 5:57 AM

Harbormaster completed remote builds in B1654: Diff 39377.Aug 10 2018, 5:57 AM

mlaurent edited the summary of this revision. (Show Details)Aug 10 2018, 5:58 AM

mlaurent added a reviewer: vkrause.

Add rentalcar element

Harbormaster completed remote builds in B1656: Diff 39379.Aug 10 2018, 6:13 AM

Looks good. I think we still need to register RentalCar in JsonLdDocument for deserialization to work though. With that line added this can go in.

This revision is now accepted and ready to land.Aug 10 2018, 6:21 AM

vkrause added inline comments.Aug 10 2018, 6:23 AM

src/calendarhandler.cpp
385	this should just be reservation.reservationFor().value<RentalCar>(), no?

Use rentalCar().name()

Harbormaster completed remote builds in B1657: Diff 39380.Aug 10 2018, 6:52 AM

We need to process location too

Harbormaster completed remote builds in B1658: Diff 39381.Aug 10 2018, 6:56 AM

vkrause accepted this revision.Aug 10 2018, 7:17 AM

Closed by commit R1003:b96ef6b724bb: Implement fill event (authored by mlaurent). · Explain WhyAug 10 2018, 7:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/CMakeLists.txt (2 lines)
M			src/calendarhandler.cpp (45 lines)
A	M		src/datatypes/rentalcar.h (45 lines)
A	M		src/datatypes/rentalcar.cpp (40 lines)
M			src/extractorpostprocessor.cpp (10 lines)
M			src/jsonlddocument.cpp (2 lines)
M			src/mergeutil.cpp (24 lines)
M			src/sortutil.cpp (8 lines)

Diff 39383

CMakeLists.txt

Loading...

src/CMakeLists.txt

Loading...

src/calendarhandler.cpp

Loading...

src/datatypes/rentalcar.h

Loading...

src/datatypes/rentalcar.cpp

Loading...

src/extractorpostprocessor.cpp

Loading...

src/jsonlddocument.cpp

Loading...

src/mergeutil.cpp

Loading...

src/sortutil.cpp

Loading...