Differential D14716

Fix missing notification title found by -Wswitch-enum
ClosedPublic
Actions

Authored by rkflx on Aug 9 2018, 8:10 PM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Commits
R166:6eebb57e6e1f: Fix missing notification title found by -Wswitch-enum
Summary

When capturing a screenshot in background mode or when
Quit after Save or Copy is checked, Spectacle shows a notfication.

Normally that notification has the capture mode set as the title, but
for Window Under Cursor it was missing (in case
Capture the current pop-up only was unchecked too).

This was due to one missing case in a switch statement, found by using
stricter compiler warnings.

FIXED-IN: 18.08.1

Test Plan

spectacle -ub should include a title in the notification again.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Aug 9 2018, 8:10 PM
rkflx created this revision.
ngraham accepted this revision.Aug 10 2018, 2:51 PM
This revision is now accepted and ready to land.Aug 10 2018, 2:51 PM
Closed by commit R166:6eebb57e6e1f: Fix missing notification title found by -Wswitch-enum (authored by rkflx). · Explain WhyAug 12 2018, 6:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/SpectacleCore.cpp (1 line)

Diff 39487

View Options

src/SpectacleCore.cpp

Loading...