Differential D14714

[effects/mousemark] Properly use GL_LINE_SMOOTH
ClosedPublic
Actions

Authored by zzag on Aug 9 2018, 6:33 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:99804e0233cb: [effects/mousemark] Properly use GL_LINE_SMOOTH
Summary

We need to enable GL_BLEND for line smoothing to work.

CCBUG: 337044

Test Plan

Before:

After:

Diff Detail

Repository
R108 KWin
Branch
effects-mousemark-properly-use-line-smooth
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1647
Build 1665: arc lint + arc unit
zzag created this revision.Aug 9 2018, 6:33 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 9 2018, 6:33 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 9 2018, 6:33 PM
zzag edited the test plan for this revision. (Show Details)Aug 9 2018, 6:34 PM

With antialiasing, the lines still look like crap. :(

zzag updated this revision to Diff 39365.Aug 9 2018, 6:38 PM

Add whitespace after comma

davidedmundson accepted this revision.Aug 9 2018, 6:40 PM
davidedmundson added a subscriber: davidedmundson.

screenshots look the same to me, but method documentation says it should .

This revision is now accepted and ready to land.Aug 9 2018, 6:40 PM
Closed by commit R108:99804e0233cb: [effects/mousemark] Properly use GL_LINE_SMOOTH (authored by zzag). · Explain WhyAug 9 2018, 7:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/mousemark/mousemark.cpp (5 lines)

Diff 39365

View Options

effects/mousemark/mousemark.cpp

Loading...