Bump QT_MIN_VERSION and KF5_MIN_VERSION
ClosedPublic

Authored by rkflx on Aug 9 2018, 8:19 AM.

Details

Summary

28754fa2d95e broke compiling Gwenview with Qt 5.6:

lib/historymodel.cpp: In member function ‘void Gwenview::HistoryModelPrivate::load()’:
lib/historymodel.cpp:170:72: error: lambda-expression in unevaluated context
         Q_FOREACH(const QString & name, dir.entryList(QStringList() << QStringLiteral("*rc"))) {

Given that at some point we had to move on to a newer Qt anyway, we
might as well do that now. Since Qt 5.9 is an LTS release and available
in the stable versions of major distros [1], it seems like a good fit.
Okular and Dolphin are already asking for Qt 5.8 too (but Qt 5.8 is
neither supported nor widely used anymore).

While at it, we also bump the KF5 version, to make testing the oldest
supported baseline easier and allow for some #ifdef cleanup later on.
Here 5.43 seems like a good choice [2] (Dolphin uses the same version).

[1] https://repology.org/metapackage/qt5-base/versions
[2] https://repology.org/metapackage/kwidgetsaddons/versions

Test Plan

Should still compile on openSUSE Leap 15.0 and Ubuntu 18.04.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Aug 9 2018, 8:19 AM
rkflx created this revision.
rkflx added a comment.Aug 9 2018, 8:22 AM

(I'll clean up the #ifdefs separately, mainly asking for general consensus for the version bump here.)

ngraham accepted this revision.Aug 10 2018, 4:54 PM
ngraham added a subscriber: ngraham.

+1 for me. I don't see anything wrong with depending on an LTS Qt version. Distros that are still shipping very old versions of Qt aren't going to be shipping bleeding-edge versions of Gwenview--or KDE Applications more generally.

This revision is now accepted and ready to land.Aug 10 2018, 4:54 PM
rkflx added a comment.Aug 13 2018, 8:35 PM

Distros that are still shipping very old versions of Qt aren't going to be shipping bleeding-edge versions of Gwenview--or KDE Applications more generally.

True, but only caring about whether distros can compile Gwenview would be a bit short-sighted, because also individual tech-savvy users of a particular distro might want to compile Gwenview from master, e.g. to get a bug fix. They need this exactly because and even though their distro won't do it for them. But as I said, major distros are providing Qt 5.9 and a new enough KF 5, so it's probably fine.

This revision was automatically updated to reflect the committed changes.

(I'll clean up the #ifdefs separately, mainly asking for general consensus for the version bump here.)

Done in 2f18ec3383a2.