X11: set GDK_SCALE (try 2)

Authored by eszlari on Aug 8 2018, 6:42 PM.



BUG: 387849

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
eszlari created this revision.Aug 8 2018, 6:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2018, 6:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
eszlari requested review of this revision.Aug 8 2018, 6:42 PM
ngraham accepted this revision.Aug 13 2018, 1:24 PM
ngraham added a reviewer: Plasma.

Tested this out and it works flawlessly for Firefox, Lollypop, and GIMP (to the extent that GIMP does support HiDPI) with the integer scale factor use case as long as the Font DPI settings haven't been monkeyed with. But that would be a separate issue, since they are known to conflict.

This revision is now accepted and ready to land.Aug 13 2018, 1:24 PM
broulik requested changes to this revision.Aug 13 2018, 1:46 PM
broulik added a subscriber: broulik.

Please hang on, we need to more thorougly test this.

This revision now requires changes to proceed.Aug 13 2018, 1:46 PM

It works well enough for me so far. Can we get some more testing?

ngraham added a comment.EditedOct 9 2018, 4:45 PM

@broulik 5.14 was just released; should we give this a shot for 5.15?

broulik added inline comments.Oct 9 2018, 4:49 PM

Where does kdeglobals_kscreen_scalefactor come from?

eszlari added inline comments.Oct 9 2018, 6:39 PM

Line 52.

davidedmundson added inline comments.Oct 9 2018, 11:18 PM

kstartupconfig5, which reads startupconfigkeys to see what to extract. They then get set as env vars.

broulik resigned from this revision.Oct 18 2018, 4:45 PM

I guess this can go in so we can have a full cycle of testing?

I think that would make sense. @davidedmundson do you agree? It would be nice to have three months to live with this and see if there are any bugs (my testing is clean FWIW).

This comment was removed by ngraham.

@eszlari, can you provide an email address so we can land this with the proper authorship information?


This revision was not accepted when it landed; it landed in state Needs Revision.Oct 18 2018, 10:43 PM
Closed by commit R120:31e1a1a96ca2: X11: set GDK_SCALE (try 2) (authored by eszlari, committed by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.