[effects/sheet] Fix undesired perspective distortion
ClosedPublic

Authored by zzag on Aug 8 2018, 10:01 AM.

Details

Summary

If a modal window is near some of screen edges, it will be distorted
in undesired way when it's being animated.

In order to keep perspective distortions invariant, no matter where
the modal window is on the screen, we have to move that modal window
to the origin, scale it, rotate it, translate it, apply perspective projection,
and then move it back.

Test Plan
  • Opened Kate
  • Opened "Open File" dialog (during the in animation, it was distorted as expected)
  • Closed that dialog (during the out animation, it was distorted as expected)

Diff Detail

Repository
R108 KWin
Branch
effects-sheet-fix-distortions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1612
Build 1630: arc lint + arc unit
zzag created this revision.Aug 8 2018, 10:01 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 8 2018, 10:01 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 8 2018, 10:01 AM
zzag added a comment.EditedAug 8 2018, 10:05 AM

I wonder why no one submitted a bug report about this issue..

zzag updated this revision to Diff 39298.Aug 8 2018, 10:08 AM

Fix copy-paste typo

zzag edited the summary of this revision. (Show Details)Aug 8 2018, 10:10 AM
zzag edited the summary of this revision. (Show Details)
davidedmundson accepted this revision.Aug 8 2018, 10:18 AM
davidedmundson added a subscriber: davidedmundson.

I wonder why no one has submitted a bug report about this issue..

I assumed it was meant to look like that.

This revision is now accepted and ready to land.Aug 8 2018, 10:18 AM
This revision was automatically updated to reflect the committed changes.