- Use new connect syntax
- Fix coding style
- Port to TimeLine
- Delete unused includes
- Use interpolate helper
- Drop WindowInfo class
Behavior of this effect hasn't been changed.
davidedmundson |
KWin |
Behavior of this effect hasn't been changed.
Opened/closed an "Open File" dialog, it still flies in/out.
No Linters Available |
No Unit Test Coverage |
Buildable 1624 | |
Build 1642: arc lint + arc unit |
5.14 would include pretty big number of effect changes so I think this patch can wait for 5.15. It's not that urgent.
effects/sheet/sheet.h | ||
---|---|---|
73–82 | I think, it's not mandatory, but since you change code style, does it better for function implementation to go in cpp files only. |
effects/sheet/sheet.h | ||
---|---|---|
73–82 | AFAIK, all effects implement getters for properties in header files. So, I don't want this effect to deviate from the rest. |
Ship it!
effects/sheet/sheet.h | ||
---|---|---|
26 | Not that I mind, but you just made a whole commit about pointless comments... |
effects/sheet/sheet.h | ||
---|---|---|
26 | I think that's fine in this case. It would tell people where to put includes. E.g. sometimes I see the following pattern Qt includes KF includes Qt includes FWIW, in most cases, those includes are not sorted so there is a chance of adding duplicate includes Also, most of KWin codebase does the same(adds include comments). |