Fix GCC warning
ClosedPublic

Authored by volden on Aug 7 2018, 7:31 PM.

Details

Reviewers
aaronpuchert
Group Reviewers
KDevelop
Commits
R32:48e2d83c6239: Fix GCC warning
Summary

Fix catching polymorphic type ‘class svn::ClientException’ by value [-Wcatch-value=] on GCC

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volden created this revision.Aug 7 2018, 7:31 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 7 2018, 7:31 PM
volden requested review of this revision.Aug 7 2018, 7:31 PM
aaronpuchert accepted this revision.Aug 7 2018, 9:39 PM
aaronpuchert added a subscriber: aaronpuchert.

Maybe you can also activate the warning (as error) in CMakeLists.txt?

This revision is now accepted and ready to land.Aug 7 2018, 9:39 PM
This revision was automatically updated to reflect the committed changes.
volden added a comment.Aug 9 2018, 7:20 AM

@aaronpuchert I can certainly look into it. But if I remember correctly, there are a massive amount of deprecated warnings coming from the subversion code. More specifically svncpp library. So i doubt that it would be possible.