for consistency, when IconApplet calls this method it shouldn't use
a readonly lineedit, but a QLabel.
Details
Details
locally hacked tests/kpropertiesdialogtest.cpp to add a call to
setFileNameReadOnly(true)
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- kpropsdlg
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1608 Build 1626: arc lint + arc unit
Comment Actions
Thanks for the help. Works great, just one inline question about an edge case (everything else LGTM).
| src/widgets/kpropertiesdialog.cpp | ||
|---|---|---|
| 853 | Just out of interest (don't change anything): I assume you don't fully transition everything to d->m_grid to keep the diff small, or because grid is more readable? | |
| 1211–1214 | Wouldn't this mean that calling setFileNameReadOnly(true) multiple times will also create multiple labels on top of each other, breaking idempotence and resulting in some kind of bold font effect? | |
| src/widgets/kpropertiesdialog.cpp | ||
|---|---|---|
| 853 | Yeah, a bit of both, mostly to keep the diff small. Most of the usage of grid is here in that method, we need it in a member only for one call, so it seems a bit overkill to use the member everywhere. | |
| 1211–1214 | Fair point, I'll just add a check that d->m_fileNameLabel doesn't exist already. | |