Fwupd-Backend (Fixes)
ClosedPublic

Authored by abhijeet2096 on Aug 6 2018, 1:07 PM.

Details

Summary

This Patch brings the following fixes:

  • Now It shows proper release data.
  • Now showing proper size.
  • added a default icon for updates (device-notifier)
  • fixes some end-case

Diff Detail

Repository
R134 Discover Software Store
Lint
Lint Skipped
Unit
Unit Tests Skipped
abhijeet2096 created this revision.Aug 6 2018, 1:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 6 2018, 1:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
abhijeet2096 requested review of this revision.Aug 6 2018, 1:07 PM
apol added a comment.Aug 6 2018, 1:34 PM

Reviewing the patch with such menial styling changes becomes to hard, please clean up first.

The spaces change is indeed correct, maybe just commit that part first, for easier review.

libdiscover/backends/FwupdBackend/FwupdBackend.h
84 ↗(On Diff #39188)

Why did you change all device to dev?

sure

libdiscover/backends/FwupdBackend/FwupdBackend.h
84 ↗(On Diff #39188)

I was using "rel" for releases, so for uniformity, I changed the devices to "dev".

apol added inline comments.Aug 6 2018, 1:43 PM
libdiscover/backends/FwupdBackend/FwupdBackend.h
84 ↗(On Diff #39188)

Not a big fan, please revert. If anything change rel to release.

ngraham added a subscriber: ngraham.Aug 6 2018, 1:43 PM
ngraham added inline comments.
libdiscover/backends/FwupdBackend/FwupdBackend.h
84 ↗(On Diff #39188)

How about instead using "releases" for "releases?" :) Short variable names are a false economy.

abhijeet2096 added inline comments.Aug 6 2018, 1:44 PM
libdiscover/backends/FwupdBackend/FwupdBackend.h
84 ↗(On Diff #39188)

okay sure!

abhijeet2096 edited the summary of this revision. (Show Details)
abhijeet2096 edited the summary of this revision. (Show Details)

This diff only contains the changes and fixes related to the size of releases show. All the changes related to space and name are committed directly!

apol accepted this revision.Aug 6 2018, 4:04 PM
This revision is now accepted and ready to land.Aug 6 2018, 4:04 PM
This revision was automatically updated to reflect the committed changes.