Differential D14645

clang: Fix crash in completion on unexpectedly missing FunctionType
AbandonedPublic
Actions

Authored by kossebau on Aug 6 2018, 10:32 AM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Summary

Move the whole code section into a single "if (f)" branch to avoid having to
repeatedly checking for the existance (which was missing for getting the
returnTypeIntegral as seen in the backtrace of a reported crash).

Diff Detail

Repository
R32 KDevelop
Branch
dontcrashoncompletion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1559
Build 1577: arc lint + arc unit
kossebau created this revision.Aug 6 2018, 10:32 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 6 2018, 10:32 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Aug 6 2018, 10:32 AM
brauch accepted this revision.Aug 6 2018, 10:36 AM

We should try to figure out what code leads to creating a function declaration with no function type assigned, but this check makes sense in any case. Thank you!

This revision is now accepted and ready to land.Aug 6 2018, 10:36 AM
kossebau abandoned this revision.Aug 6 2018, 11:15 AM

Discarding in favour of now pushed 9bb84876534f551522e548b0d5dc435314231166 which reapplies a patch pushed to 5.2 but lost in the merge to master.

Revision Contents
Changeset List

Diff 39176

View Options

plugins/clang/codecompletion/context.cpp

Loading...