Differential D14641

Refine wording when a folder with an invalid name could not be created
ClosedPublic
Actions

Authored by ngraham on Aug 5 2018, 10:20 PM.

Details

Reviewers
tmarshall
elvisangelaccio
Group Reviewers
Dolphin
Frameworks
VDG
Commits
R241:df9513397850: Refine wording when a folder with an invalid name could not be created
Summary

This is follow-on for D13805 that improves the wording to be less redundant and a little bit clearer.

Test Plan

Before:

After:

Diff Detail

Repository
R241 KIO
Branch
refine-wording (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1550
Build 1568: arc lint + arc unit
ngraham created this revision.Aug 5 2018, 10:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 5 2018, 10:20 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 5 2018, 10:20 PM
ngraham edited the test plan for this revision. (Show Details)Aug 5 2018, 10:21 PM
ngraham retitled this revision from Refine wording when a folder with an invalid name could not be creted to Refine wording when a folder with an invalid name could not be created.
markuss added a subscriber: markuss.EditedAug 6 2018, 12:01 AM

If you remove the manual new-line, will everything be in a single line with a wide window or will Qt just add a line break where it fits?

I ask because with a short name like ".." the line break looks unnatural as if the next line is a new sentence.

ngraham added a comment.Aug 6 2018, 1:54 AM
In D14641#304077, @markuss wrote:

If you remove the manual new-line, will everything be in a single line with a wide window or will Qt just add a line break where it fits?

The window becomes really wide, yeah. That's why I added a manual line break.

elvisangelaccio accepted this revision.Aug 7 2018, 8:46 PM
This revision is now accepted and ready to land.Aug 7 2018, 8:46 PM
ngraham closed this revision.Aug 7 2018, 9:05 PM
markuss removed a subscriber: markuss.Aug 7 2018, 9:33 PM

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/knewfilemenu.cpp (2 lines)

Diff 39156

View Options

src/filewidgets/knewfilemenu.cpp

Loading...