Use appropriate icon for a cancel button that will ask for a new name
ClosedPublic
Actions

Authored by ngraham on Aug 5 2018, 10:10 PM.

Details

Reviewers

Group Reviewers

Frameworks
VDG

Commits

R241:2a1566c13690: Use appropriate icon for a cancel button that will ask for a new name

Summary

When a dialog has a cancel button that says, "Enter a different name", give that button the edit-rename icon instead of the standard cancel icon.

Test Plan

Diff Detail

Repository

R241 KIO

Branch

rename-icons (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1548
Build 1566: arc lint + arc unit

ngraham created this revision.Aug 5 2018, 10:10 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 5 2018, 10:10 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Aug 5 2018, 10:10 PM

Harbormaster completed remote builds in B1548: Diff 39154.Aug 5 2018, 10:10 PM

ngraham edited the summary of this revision. (Show Details)Aug 5 2018, 10:11 PM

ngraham edited the test plan for this revision. (Show Details)

Bug in the commit log? You meant edit-rename rather than edit-delete, right?

Yes indeed, oops. Corrected.

broulik added a subscriber: broulik.Aug 6 2018, 1:19 PM

broulik added inline comments.

src/filewidgets/knewfilemenu.cpp
416	Also this needs title capitalization [1] [1] https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization

ngraham added inline comments.Aug 6 2018, 1:23 PM

src/filewidgets/knewfilemenu.cpp
416	Addressed separately in D14650.

Could the message have 2 buttons? A cancel and an "Enter a different name". That way, if the user inadvertently entered that reserved name can cancel the action still.

Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the folder.

In D14640#304400, @ngraham wrote:

Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the folder.

I am mostly trying to think of unintended actions upon unintended actions. Thinking maybe that a less knowledgeable user just took the wrong path in trying to complete an action.

In D14640#304405, @abetts wrote:

In D14640#304400, @ngraham wrote:

Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the folder.

I am mostly trying to think of unintended actions upon unintended actions. Thinking maybe that a less knowledgeable user just took the wrong path in trying to complete an action.

Now that I think about it, you're right. I'll submit a patch for that once my current crop of patches are accepted and landed. Wanna accept this one?

In D14640#304428, @ngraham wrote:

In D14640#304405, @abetts wrote:

In D14640#304400, @ngraham wrote:

Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the folder.

I am mostly trying to think of unintended actions upon unintended actions. Thinking maybe that a less knowledgeable user just took the wrong path in trying to complete an action.

Now that I think about it, you're right. I'll submit a patch for that once my current crop of patches are accepted and landed. Wanna accept this one?

Yes, no problem! Thanks for taking my suggestion.

abetts accepted this revision.Aug 6 2018, 2:37 PM

This revision is now accepted and ready to land.Aug 6 2018, 2:37 PM

ngraham closed this revision.Aug 6 2018, 10:30 PM

In D14640#304429, @abetts wrote:

In D14640#304428, @ngraham wrote:

In D14640#304405, @abetts wrote:

In D14640#304400, @ngraham wrote:

Hmm, I'm not sure a cancel button makes sense here because that would end the process of creating the folder. If you chose an invalid name, presumably you still want to create the folder.

I am mostly trying to think of unintended actions upon unintended actions. Thinking maybe that a less knowledgeable user just took the wrong path in trying to complete an action.

Now that I think about it, you're right. I'll submit a patch for that once my current crop of patches are accepted and landed. Wanna accept this one?

Yes, no problem! Thanks for taking my suggestion.

See D14663: Give the "invalid directory name" dialog a cancel button

Revision Contents
Changeset List

			Path	Packages
M			src/filewidgets/knewfilemenu.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
ec7b11dd0799	30fcbc3c3069	0799ca8f3222	Nathaniel Graham	Use appropriate icon for a cancel button that will ask for a new name (Show More…)	Aug 5 2018, 10:09 PM

Diff 39154

View Options

src/filewidgets/knewfilemenu.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39154	0799ca8		Aug 5 2018, 10:10 PM	★	★