Differential D1461

Add cmd line option to delete sessions.
ClosedPublic
Actions

Authored by cordlandwehr on Apr 21 2016, 8:03 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:3cefcec2fd56: Add cmd line option to delete sessions.
Summary

Thus supplements the already available options for adding new sessions
and simplifies the currently only available option to remove sessions, for
which a session has to be opened first.

Diff Detail

Repository
R32 KDevelop
Branch
patchRmOption
Lint
No Linters Available
Unit
No Unit Test Coverage
cordlandwehr updated this revision to Diff 3450.Apr 21 2016, 8:03 PM
cordlandwehr retitled this revision from to Add cmd line option to delete sessions..
cordlandwehr updated this object.
cordlandwehr edited the test plan for this revision. (Show Details)
cordlandwehr added a subscriber: kdevelop-devel.
kfunk requested changes to this revision.Apr 22 2016, 7:48 AM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.
kfunk added inline comments.
app/main.cpp
553 ↗(On Diff #3450)

Can you use findSessionId here?

This revision now requires changes to proceed.Apr 22 2016, 7:48 AM
cordlandwehr updated this revision to Diff 3461.Apr 22 2016, 4:14 PM
cordlandwehr edited edge metadata.
  • Add cmd line option to delete sessions.
  • Reuse findSessionInList method.
kfunk accepted this revision.Apr 22 2016, 4:34 PM
kfunk edited edge metadata.

LGTM

It'd be awesome if you could move the (multiple) qerr/qout definitions into the main() scope, in a follow-up commit.

This revision is now accepted and ready to land.Apr 22 2016, 4:34 PM
kfunk added a comment.Apr 22 2016, 4:36 PM
In D1461#27167, @kfunk wrote:

LGTM

It'd be awesome if you could move the (multiple) qerr/qout definitions into the main() scope, in a follow-up commit.

Or, well, not necessary. Nevermind.

Closed by commit R32:3cefcec2fd56: Add cmd line option to delete sessions. (authored by cordlandwehr). · Explain WhyApr 24 2016, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/main.cpp (22 lines)

Diff 3461

View Options

app/main.cpp

Loading...