Runner for executing commands on remote device
ClosedPublic
Actions

Authored by nicolasfella on Aug 4 2018, 2:46 PM.

Details

Reviewers

broulik
davidedmundson
apol

Group Reviewers

KDE Connect
Plasma

Commits

R224:8a9c95dde96b: Runner for executing commands on remote device
R224:c17227b6c940: Runner for executing commands on remote device

Summary

Add a runner that allows executing commands on a connected device. It enables a more keyboard-centric workflow than running the commands from the plasmoid.

Test Plan

Connect desktop device. Add some commands there. restart krunner, open it, start typing command or device name. Select entry to execute command. Check for success.

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Aug 4 2018, 2:46 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 4 2018, 2:46 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Aug 4 2018, 2:46 PM

Harbormaster completed remote builds in B1511: Diff 39068.Aug 4 2018, 2:46 PM

ngraham added a subscriber: ngraham.Aug 4 2018, 4:39 PM

apol requested changes to this revision.Aug 4 2018, 5:55 PM

apol added a subscriber: apol.

apol added inline comments.

CMakeLists.txt
103	Maybe it would make sense to have a plasma-integration directory with runners and plasmoid?
runners/remotecommands/remotecommandsrunner.cpp
51	const &, also this is a blocking dbus call. It would make sense to use the async API.
66	const, and below.

This revision now requires changes to proceed.Aug 4 2018, 5:55 PM

davidedmundson added inline comments.Aug 4 2018, 5:59 PM

runners/remotecommands/remotecommandsrunner.cpp
51	you're in your own thread here. Being async doesn't really gain you too much.

const

Harbormaster completed remote builds in B1879: Diff 39803.Aug 15 2018, 6:35 PM

nicolasfella added inline comments.Aug 15 2018, 6:38 PM

runners/remotecommands/remotecommandsrunner.cpp
51	If you really want it async I'll do it, it's your call

apol accepted this revision.Feb 8 2019, 10:44 PM

apol added inline comments.

runners/remotecommands/remotecommandsrunner.cpp
51	Are all KRunner plugins in a separate thread?

This revision is now accepted and ready to land.Feb 8 2019, 10:44 PM

Closed by commit R224:8a9c95dde96b: Runner for executing commands on remote device (authored by nicolasfella). · Explain WhyFeb 8 2019, 11:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (6 lines)
A	M	runners/CMakeLists.txt (1 line)
A	M	runners/remotecommands/CMakeLists.txt (7 lines)
A	M	runners/remotecommands/Messages.sh (2 lines)
A	M	runners/remotecommands/plasma-runner-kdeconnect-remotecommands.desktop (13 lines)
A	M	runners/remotecommands/remotecommandsrunner.h (45 lines)
A	M	runners/remotecommands/remotecommandsrunner.cpp (91 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	39068	36aecee		Aug 4 2018, 2:46 PM	★	★
Diff 2	39803	36aecee	- const	Aug 15 2018, 6:35 PM	★	★
Diff 3	51226	9579758	R224:8a9c95dde96bcb427b68ddd515ccca9808d7396f	Feb 8 2019, 10:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d881cbba385c	eeb1a434dcf7	393d97d30ab8	Nicolas Fella	const	Aug 15 2018, 6:34 PM
393d97d30ab8	788576edd8c2	36aecee42964	Nicolas Fella	Runner for executing commands on remote device (Show More…)	Aug 15 2018, 6:31 PM