Differential D14599

Rename libbreezecommon to libbreezecommon5 and don't install .so links
ClosedPublic
Actions

Authored by fvogt on Aug 4 2018, 12:43 PM.

Details

Reviewers
zzag
Group Reviewers
Breeze
Commits
R31:763ec6d33541: Rename libbreezecommon to libbreezecommon5 and don't install .so links
Summary

libbreezecommon is not meant to be used outside of breeze (it can't, no headers
are installed) so the .so link is not necessary.

Additionally, rename libbreezecommon.so.5 to libbreezecommon5.so.5 for symmetry
with libbreezecommon4.so.5.

Test Plan

Built and installed it - still works.

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Aug 4 2018, 12:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 4 2018, 12:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt requested review of this revision.Aug 4 2018, 12:43 PM
zzag accepted this revision.Aug 4 2018, 12:50 PM

Would prefer to have another patch for renaming breezecommon to breezecommon5, but I think that's fine. Thanks. :-)

Also, maybe, you need to do the same for Oxygen (liboxygen).

... yet another also, please add BUG or CCBUG.

This revision is now accepted and ready to land.Aug 4 2018, 12:50 PM
fvogt updated this revision to Diff 39062.Aug 4 2018, 1:15 PM

BUG: 397145

Closed by commit R31:763ec6d33541: Rename libbreezecommon to libbreezecommon5 and don't install .so links (authored by fvogt). · Explain WhyAug 4 2018, 1:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39064

View Options

kdecoration/CMakeLists.txt

Loading...
View Options

kstyle/CMakeLists.txt

Loading...
View Options

libbreezecommon/CMakeLists.txt

Loading...