Rename libbreezecommon to libbreezecommon5 and don't install .so links
ClosedPublic

Authored by fvogt on Aug 4 2018, 12:43 PM.

Details

Summary

libbreezecommon is not meant to be used outside of breeze (it can't, no headers
are installed) so the .so link is not necessary.

Additionally, rename libbreezecommon.so.5 to libbreezecommon5.so.5 for symmetry
with libbreezecommon4.so.5.

Test Plan

Built and installed it - still works.

Diff Detail

Repository
R31 Breeze
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1506
Build 1524: arc lint + arc unit
fvogt created this revision.Aug 4 2018, 12:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 4 2018, 12:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt requested review of this revision.Aug 4 2018, 12:43 PM
zzag accepted this revision.Aug 4 2018, 12:50 PM

Would prefer to have another patch for renaming breezecommon to breezecommon5, but I think that's fine. Thanks. :-)

Also, maybe, you need to do the same for Oxygen (liboxygen).

... yet another also, please add BUG or CCBUG.

This revision is now accepted and ready to land.Aug 4 2018, 12:50 PM
fvogt updated this revision to Diff 39062.Aug 4 2018, 1:15 PM

BUG: 397145

This revision was automatically updated to reflect the committed changes.