Differential D14566

Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake
ClosedPublic
Actions

Authored by abhijeet2096 on Aug 2 2018, 8:36 PM.

Details

Reviewers
apol
davidedmundson
Commits
R134:a55b13c3f3a5: Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake
Summary

There was no check condition, that the variables in FINDLIBFWUPD.cmake file is set or unset. This diff checks for it. Also, there was a discrepancy for fwupd lib to required or optional, this fixes it. After applying this patch, the build errors are fixed.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abhijeet2096 created this revision.Aug 2 2018, 8:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 2 2018, 8:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
abhijeet2096 requested review of this revision.Aug 2 2018, 8:36 PM
apol accepted this revision.Aug 2 2018, 9:36 PM
This revision is now accepted and ready to land.Aug 2 2018, 9:36 PM
Closed by commit R134:a55b13c3f3a5: Fix Build Fails Due to variable Not set in FINDLIBFWUPD.cmake (authored by abhijeet2096). · Explain WhyAug 3 2018, 2:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Mcmake/FindLIBFWUPD.cmake (3 lines)

Diff 38991

View Options

CMakeLists.txt

Loading...
View Options

cmake/FindLIBFWUPD.cmake

Loading...