Fix overflow in rounding code
ClosedPublic

Authored by svuorela on Aug 2 2018, 8:12 PM.

Details

Summary

qRound works with int.

BUG: 397008

Test Plan

add unit tests

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1467
Build 1485: arc lint + arc unit
svuorela created this revision.Aug 2 2018, 8:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 2 2018, 8:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
svuorela requested review of this revision.Aug 2 2018, 8:12 PM
safaalfulaij accepted this revision.Aug 2 2018, 8:38 PM

Worked great, thanks!
Maybe you should use largeValue instead of largevalue.
But please take an approval from a developer, it worked for me but I have no idea if it can cause any trouble :)

This revision is now accepted and ready to land.Aug 2 2018, 8:38 PM
cfeck requested changes to this revision.Aug 2 2018, 9:37 PM

Maybe you should use largeValue instead of largevalue.

Yes, that would be consistent with what we do elsewhere.

I had hoped a junior would grab this ticket before a senior ruins the show (insert emoticon here), but having a fast fix for 5.49.0 is surely also nice.

This revision now requires changes to proceed.Aug 2 2018, 9:37 PM
svuorela updated this revision to Diff 39024.Aug 3 2018, 3:43 PM

s/largevalue/largeValue/

Maybe you should use largeValue instead of largevalue.

Yes, that would be consistent with what we do elsewhere.

Done.

I had hoped a junior would grab this ticket before a senior ruins the show (insert emoticon here), but having a fast fix for 5.49.0 is surely also nice.

I was considering leaving it for another week or two, but then I would probably have forgotten about it.

cfeck accepted this revision.Aug 3 2018, 3:59 PM

Merci!

This revision is now accepted and ready to land.Aug 3 2018, 3:59 PM
This revision was automatically updated to reflect the committed changes.