Fixes a regression from ac59cc7e007a3ef73a07.
LibreOffice Writer, for example, will hang during startup when
QT_NO_GLIB is set. It uses GLib and has KDE integration.
Details
Details
In a shell, set QT_NO_GLIB to a string, or an empty string, or
unset it. Run konsole from that shell, check that QT_NO_GLIB in
the new shell inside konsole has the same value as in the
launching shell.
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@sandsmark , it would be good to retest if your fix still works after this. IIRC QApplication does not lazily initialize the event loop though.
Comment Actions
Ah, I was really wondering what I did wrong to suddenly get QT_NO_GLIB... (I normally only set it when using helgrind or thread-sanitizer....). Thanks for the fix!
Comment Actions
Thanks for the fix! BTW for future reference, the preferred workflow for bugfixes is to commit to the stable branch (Applications/18.08` in this case) and then merge to master, rather than cherry-picking to the stable branch after first landing on master.
Comment Actions
For Konsole, I've always done the reverse - I'd rather the stable branches were actually stable, so test in master first.
Comment Actions
I meant just as a merging strategy. This patch landed in both branches, after all--not just master.
Comment Actions
Ah, that's because I backported it (from master, using cherry-pick), I thought it was just a mistake that it didn't land in the stable branch.