The model was changed a while ago to return a QString if possible to have icon processing done in the delegate QML on-demand. This broke the drag helper's drag pixmap, however, as the QML would pass in model.decoration which might be a string.
Details
Details
- Reviewers
apol davidedmundson - Group Reviewers
Plasma - Commits
- R112:816a923f7c05: Support both QString and QIcon for dragHelper pixmap
5.12
- Have proper drag pixmaps for all entries again
- Custom icons (e.g. favicon) still work
Diff Detail
Diff Detail
- Repository
- R112 Milou
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| lib/draghelper.h | ||
|---|---|---|
| 47–48 | This is an exported method, is this not a public library? :/ | |
| lib/draghelper.h | ||
|---|---|---|
| 47–48 | Milou is released as part of plasma and this class is only for QML use, don't recall why it's exported anymore but there's also no header installed for it. As far as QML is concerned, a function call will still work as before. | |
Comment Actions
Turns out the library is really exported and the qml plugin just links to it rather than "be" that library.
- Add another overload instead