Honor BUILD_TESTING
ClosedPublic

Authored by heikobecker on Aug 1 2018, 4:29 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R40:7a6e7342ef5a: Honor BUILD_TESTING
Summary

Although ecm_optional_add_subdirectory(autotests) allows to skip
building the autotests with -DBUILD_autotests=FALSE, it doesn't seem
reasonable to have two options controlling similar behaviour and
BUILD_TESTING is the de-facto standard for cmake and already used
when discovering Qt5::Test.

Furthermore it avoids a cmake warning when BUILD_TESTING is set to
FALSE because Qt5::Test is passed to target_link_libraries but
isn't a valid target.

Test Plan

Warning disappears and builds successfully

Diff Detail

Repository
R40 Kate
Branch
Applications/18.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1432
Build 1450: arc lint + arc unit
heikobecker created this revision.Aug 1 2018, 4:29 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 1 2018, 4:29 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
heikobecker requested review of this revision.Aug 1 2018, 4:29 PM
cullmann accepted this revision.Aug 1 2018, 7:34 PM
cullmann added a subscriber: cullmann.

As frameworks use the same method, I guess that makes sense.

This revision is now accepted and ready to land.Aug 1 2018, 7:34 PM
This revision was automatically updated to reflect the committed changes.