Differential D14531

[Icon Item] Use ItemEnabledHasChanged
ClosedPublic
Actions

Authored by broulik on Aug 1 2018, 8:50 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:e143f7d457f6: [Icon Item] Use ItemEnabledHasChanged
Summary

Preferred over having a connect and it go through meta signal invocation when it's emitted

Test Plan

New in Qt 5.10, same was done with visible a while ago
Icon enabled state in e.g. fullscreen dashboard working fine
Iconitem test still passes

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 1 2018, 8:50 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 1 2018, 8:50 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Aug 1 2018, 8:50 AM
davidedmundson accepted this revision.Aug 17 2018, 1:39 PM
This revision is now accepted and ready to land.Aug 17 2018, 1:39 PM
Closed by commit R242:e143f7d457f6: [Icon Item] Use ItemEnabledHasChanged (authored by broulik). · Explain WhyAug 17 2018, 1:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39923

View Options

src/declarativeimports/core/iconitem.cpp

Loading...