Android: Make sure we're looking for .mo files in the right path
ClosedPublic

Authored by apol on Aug 1 2018, 12:07 AM.

Details

Summary

QStandardPaths won't be giving us the file we need, instead just point at where
we know it's going to be.

Test Plan

Was able to run KAlgebra in catalan

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Aug 1 2018, 12:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 1 2018, 12:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Aug 1 2018, 12:07 AM

Is this a possible Qt bug where the output of QStandardPaths should be tuned on Android?

apol added a comment.Aug 1 2018, 2:33 PM

Is this a possible Qt bug where the output of QStandardPaths should be tuned on Android?

Not really, QStandardPaths are something that feels quite alien to Android already. We could look into changing how we generate apks to match the current codebase but it will still mean to have some if(ANDROID) somewhere else.

ckertesz accepted this revision.Aug 2 2018, 10:05 PM

I think this is fine.

This revision is now accepted and ready to land.Aug 2 2018, 10:05 PM
apol updated this revision to Diff 38984.Aug 2 2018, 10:48 PM

Check the build directory for po/ as well

aacid added a subscriber: aacid.Aug 2 2018, 11:04 PM

As I am arguing in the other review, let's install the files in a nicer place? We control were we install them, no?

apol updated this revision to Diff 38987.Aug 3 2018, 12:10 AM

Merged another patch, sorry

This revision was automatically updated to reflect the committed changes.