Differential D14517

[effects] Move Fall Apart and Sheet to the Candy category
ClosedPublic
Actions

Authored by zzag on Jul 31 2018, 4:25 PM.

Details

Reviewers
ngraham
davidedmundson
Group Reviewers
KWin
Plasma
VDG
Commits
R108:e615b25957fd: [effects] Move Fall Apart and Sheet to the Candy category
Summary

The Fall Apart effect and the Sheet effect look like "candies" so
let's move them to corresponding category.

Test Plan

Diff Detail

Repository
R108 KWin
Branch
effects-move-fallapart-and-sheet-to-candy-category
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1404
Build 1422: arc lint + arc unit
zzag created this revision.Jul 31 2018, 4:25 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 31 2018, 4:25 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 31 2018, 4:25 PM
zzag edited the test plan for this revision. (Show Details)Jul 31 2018, 4:26 PM
ngraham accepted this revision.Jul 31 2018, 4:30 PM
ngraham added a subscriber: ngraham.

Could we also (in another patch, obviously) change the string "Candy" to "Eye Candy"?

This revision is now accepted and ready to land.Jul 31 2018, 4:30 PM
zzag added a comment.EditedJul 31 2018, 5:01 PM
In D14517#301388, @ngraham wrote:

Could we also (in another patch, obviously) change the string "Candy" to "Eye Candy"?

I think "Yes We Can" because the latter would serve much better here. (afaik, the word "candy" denotes food)

ngraham added a comment.Jul 31 2018, 5:07 PM
In D14517#301416, @zzag wrote:
In D14517#301388, @ngraham wrote:

Could we also (in another patch, obviously) change the string "Candy" to "Eye Candy"?

I think "Yes We Can" because the latter would serve much better here. (afaik, the word "candy" denotes food)

Here too. :)

"Candy" = unhealthy food
"Eye Candy" = gratuitous and unnecessary but possibly awesome visual effects

zzag added a comment.EditedJul 31 2018, 5:18 PM
In D14517#301417, @ngraham wrote:

"Candy" = unhealthy food
"Eye Candy" = gratuitous and unnecessary but possibly awesome visual effects

I'll submit another patch but only after I land this patch because managing dependencies with phab is really painful.

ngraham added a comment.Jul 31 2018, 5:23 PM

Agreed, it really is...

ngraham added a comment.Aug 2 2018, 12:42 PM

I say go for it.

davidedmundson accepted this revision.Aug 2 2018, 12:46 PM
Closed by commit R108:e615b25957fd: [effects] Move Fall Apart and Sheet to the Candy category (authored by zzag). · Explain WhyAug 2 2018, 1:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/effect_builtins.cpp (4 lines)

Diff 38855

View Options

effects/effect_builtins.cpp

Loading...