[effects] Move Fall Apart and Sheet to the Candy category
ClosedPublic

Authored by zzag on Tue, Jul 31, 4:25 PM.

Details

Summary

The Fall Apart effect and the Sheet effect look like "candies" so
let's move them to corresponding category.

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Tue, Jul 31, 4:25 PM
Restricted Application added a project: KWin. · View Herald TranscriptTue, Jul 31, 4:25 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Tue, Jul 31, 4:25 PM
zzag edited the test plan for this revision. (Show Details)Tue, Jul 31, 4:26 PM
ngraham accepted this revision.Tue, Jul 31, 4:30 PM
ngraham added a subscriber: ngraham.

Could we also (in another patch, obviously) change the string "Candy" to "Eye Candy"?

This revision is now accepted and ready to land.Tue, Jul 31, 4:30 PM
zzag added a comment.EditedTue, Jul 31, 5:01 PM

Could we also (in another patch, obviously) change the string "Candy" to "Eye Candy"?

I think "Yes We Can" because the latter would serve much better here. (afaik, the word "candy" denotes food)

In D14517#301416, @zzag wrote:

Could we also (in another patch, obviously) change the string "Candy" to "Eye Candy"?

I think "Yes We Can" because the latter would serve much better here. (afaik, the word "candy" denotes food)

Here too. :)

"Candy" = unhealthy food
"Eye Candy" = gratuitous and unnecessary but possibly awesome visual effects

zzag added a comment.EditedTue, Jul 31, 5:18 PM

"Candy" = unhealthy food
"Eye Candy" = gratuitous and unnecessary but possibly awesome visual effects

I'll submit another patch but only after I land this patch because managing dependencies with phab is really painful.

Agreed, it really is...

I say go for it.

davidedmundson accepted this revision.Thu, Aug 2, 12:46 PM
This revision was automatically updated to reflect the committed changes.