Open `skipPager` functionality
AbandonedPublic
Actions

Authored by sharvey on Jul 31 2018, 4:23 PM.

Details

Reviewers

Group Reviewers

Summary

Open skipPager functionality, same as skipTaskbar
REVIEWER NOTE: Several of the autotests are failing, although the build itself compiles correctly

#7: kwayland-testWaylandSeat
#23 kwayland-testPlasmaShell
#30 kwayland-testSelection

Test Plan

Apply patch to KWayland, compile
- Run make tests to check autotests
- See if #7, #23, #30 fail

Please help resolve.

Diff Detail

Repository

R127 KWayland

Branch

add-skip-pager (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1406
Build 1424: arc lint + arc unit

sharvey created this revision.Jul 31 2018, 4:23 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 31 2018, 4:23 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

sharvey requested review of this revision.Jul 31 2018, 4:23 PM

Harbormaster completed remote builds in B1403: Diff 38854.Jul 31 2018, 4:23 PM

Plasma team: Please help me review and fix the failing autotests. I'm not familiar enough with the internals of KWayland - or autotests - to successfully debug what's happening. The patch builds and compiles without error.

Thanks for your help.

Changes to .arclint look unintended, and I'm not sure you meant to check in CMakeLists.txt.user.

In D14516#301385, @ngraham wrote:

Changes to .arclint look unintended, and I'm not sure you meant to check in CMakeLists.txt.user.

The changes are intentional - my arc seems to be broken. It wasn't supposed to be checked in. I'll fix.

Remove untracked .arclint and CMakeLists.txt.user

Harbormaster completed remote builds in B1406: Diff 38859.Jul 31 2018, 4:39 PM

There's no functionality to remove files. I'll submit a new diff.

sharvey abandoned this revision.Jul 31 2018, 4:42 PM

Revision Contents
Changeset List

		Path
M		.arclint (20 lines)
A	M	CMakeLists.txt.user (6757 lines)
M		autotests/client/test_plasma_window_model.cpp (9 lines)
M		autotests/client/test_plasmashell.cpp (37 lines)
M		autotests/client/test_wayland_windowmanagement.cpp (1 line)
M		src/client/plasmashell.h (6 lines)
M		src/client/plasmashell.cpp (5 lines)
M		src/client/plasmawindowmanagement.h (10 lines)
M		src/client/plasmawindowmanagement.cpp (17 lines)
M		src/client/plasmawindowmodel.h (4 lines)
M		src/client/plasmawindowmodel.cpp (6 lines)
M		src/client/protocols/plasma-shell.xml (10 lines)
M		src/client/protocols/plasma-window-management.xml (3 lines)
M		src/server/plasmashell_interface.h (14 lines)
M		src/server/plasmashell_interface.cpp (19 lines)
M		src/server/plasmawindowmanagement_interface.h (2 lines)
M		src/server/plasmawindowmanagement_interface.cpp (8 lines)
M		tests/plasmasurfacetest.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	38854	5e195c2		Jul 31 2018, 4:23 PM	★	★
Diff 2	38859	5e195c2	Remove untracked `.arclint` and `CMakeLists.txt.user`	Jul 31 2018, 4:39 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0f992814a676	a869658de3c1	5e195c2a67ce	Scott Harvey	Open `skipPager` functionality (Show More…)	Jul 31 2018, 3:50 PM

Open `skipPager` functionalityAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 38859

.arclint

CMakeLists.txt.user

autotests/client/test_plasma_window_model.cpp

autotests/client/test_plasmashell.cpp

autotests/client/test_wayland_windowmanagement.cpp

src/client/plasmashell.h

src/client/plasmashell.cpp

src/client/plasmawindowmanagement.h

src/client/plasmawindowmanagement.cpp

src/client/plasmawindowmodel.h

src/client/plasmawindowmodel.cpp

src/client/protocols/plasma-shell.xml

src/client/protocols/plasma-window-management.xml

src/server/plasmashell_interface.h

src/server/plasmashell_interface.cpp

src/server/plasmawindowmanagement_interface.h

src/server/plasmawindowmanagement_interface.cpp

tests/plasmasurfacetest.cpp

Open `skipPager` functionality
AbandonedPublic
Actions

Revision Contents
Changeset List