Differential D14510

Add --mimetypes command line option
ClosedPublic
Actions

Authored by volkov on Jul 31 2018, 1:23 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Ark
Commits
R36:1bd0e369cb5b: Add --mimetypes command line option

Diff Detail

Repository
R36 Ark
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1561
Build 1579: arc lint + arc unit
volkov created this revision.Jul 31 2018, 1:23 PM
Restricted Application added a project: Ark. · View Herald TranscriptJul 31 2018, 1:23 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
volkov requested review of this revision.Jul 31 2018, 1:23 PM
volkov added a reviewer: Ark.Jul 31 2018, 1:24 PM
elvisangelaccio requested changes to this revision.Aug 4 2018, 3:36 PM
elvisangelaccio added a subscriber: elvisangelaccio.

Thanks for the patch. Just a couple of small nitpicks, looks good otherwise.

app/main.cpp
197

Please add also the short version, i.e. QStringLiteral("m")

313

Please add a space before :

This revision now requires changes to proceed.Aug 4 2018, 3:36 PM
volkov updated this revision to Diff 39178.Aug 6 2018, 10:49 AM

small fixes

volkov marked 2 inline comments as done.Aug 6 2018, 10:50 AM
elvisangelaccio accepted this revision.Aug 7 2018, 8:57 PM
This revision is now accepted and ready to land.Aug 7 2018, 8:57 PM
volkov closed this revision.Aug 7 2018, 9:06 PM

Revision Contents
Changeset List

PathPackages
Mapp/main.cpp (14 lines)

Diff 39178

View Options

app/main.cpp

Loading...