| davidedmundson |
| KWin |
Using QtQuick.Controls for Label and TextField can result in blurry font rendering for a fractional scaling (e.g. 1,5). There is a work around for QtQuick.Controls 2.x therefore using QtQuick.Controls 2.0 for Label and TextField resolves the problem
BUG: 366451
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Using QtQuick.Controls 1.0 for Label results in blurry font rendering for a fractional scaling (e.g. 1,5)
Using QQC1 or 2 is irrelevant, using native text rendering or not is the difference.
It just so happens that our particular QQC2 desktop theme sets that as a hacky workaround for fixing the real problem.
Please reflect this in the commit message.
Also, please prepend "[kcmkwin]" to the title, so it looks like
[kcmkwin] Use QtQuick.Controls 2.0 for Label
Could you please provide your real name and email address? Also, you made this patch against Plasma/5.12, right?
I've tested this patch and it seems like it introduces a visual regression:
Name of each effect and category(Accessibility, Appearance, etc) have to be bold. Is it a bug in Qt?
Also, "Search" placeholder looks bad.
Name of each effect and category(Accessibility, Appearance, etc) have to be bold. Is it a bug in Qt?
Seems so! According to the documentation "font.bold" should be perfectly valid.
Use TextField from QtQuick.Controls 2 (has the same workaround) to avoid blurry search field.
Just checked plasma-nm, they workaround the bug by using text: "<b>" + ... + "</b>". Just check it worked here as well,
will you guys accept that workaround?
Seems so! According to the documentation "font.bold" should be perfectly valid.
Not in this case
font.weight has precedent over font.bold
Our QtQuickControls2 Desktop style explicitly sets it to
font.weight: Kirigami.Theme.defaultFont.weight
If you also set font.weight it'll override that property and work.
Thanks for the patch! But it doesn't apply cleanly for me on top of KWin master:
Created and checked out branch arcpatch-D14495.
Checking patch kcmkwin/kwindecoration/qml/Buttons.qml...
error: while searching for:
Layout.fillWidth: true
anchors.centerIn: parent
height: titlebar.implicitHeight
Label {
id: titlebar
anchors.centerIn: parent
font: titleFont
error: patch failed: kcmkwin/kwindecoration/qml/Buttons.qml:70
Hunk #3 succeeded at 160 (offset -6 lines).
error: while searching for:
ColumnLayout {
anchors.centerIn: parent
visible: leftButtonsView.dragging || rightButtonsView.dragging
Label {
text: i18n("Drop here to remove button")
font.bold: true
}
KQuickControlsAddons.QIconItem {
id: icon
error: patch failed: kcmkwin/kwindecoration/qml/Buttons.qml:212
Checking patch kcmkwin/kwincompositing/qml/EffectView.qml...
Checking patch kcmkwin/kwincompositing/qml/Effect.qml...
Applying patch kcmkwin/kwindecoration/qml/Buttons.qml with 2 rejects...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
Rejected hunk #4.
Applied patch kcmkwin/kwincompositing/qml/EffectView.qml cleanly.
Applied patch kcmkwin/kwincompositing/qml/Effect.qml cleanly.
Patch Failed!
Usage Exception: Unable to apply patch!Can you re-base on master?
You have to apply it to Plasma/5.12 and then fix 2 merge conflicts (when merging Plasma/5.12 into Plasma/5.13).
@davidedmundson @bosimonsen forgot to change font.bold in kcmkwin/kwincompositing/qml/EffectView.qml:44 to font.weight. If you don't mind, I would like to change it before push.
Sure, change whatever.
We have a review process, but its not meant to be overly bureaucratic and block changes.