Differential D14489

[ProcessModel] Support high dpi for window pixmaps
AbandonedPublic
Actions

Authored by broulik on Jul 30 2018, 3:33 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Request larger pixmaps and set devicePixelRatio accordingly

Diff Detail

Repository
R111 KSysguard Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 30 2018, 3:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 30 2018, 3:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 30 2018, 3:33 PM
broulik mentioned this in D14490: [System Monitor] Enable high dpi pixmaps.
ngraham added a subscriber: ngraham.Jul 30 2018, 3:58 PM

Should this be devicePixelRatioF() to support fractional scale factors?

davidedmundson requested changes to this revision.Jul 30 2018, 4:02 PM
QPixmap KWindowSystem::icon(WId win, int width, int height, bool scale, int flags, NETWinInfo *info)
{
    Q_D(KWindowSystem);
    width *= qApp->devicePixelRatio();
    height *= qApp->devicePixelRatio();
This revision now requires changes to proceed.Jul 30 2018, 4:02 PM
broulik added a comment.Jul 30 2018, 7:58 PM

Interesting. Without this patch, I had some icons come out too small, will investigate.

davidedmundson added a comment.Jul 30 2018, 8:11 PM

KWindowSystem::icon doesn't set a DPR on the returned pixmap which sounds wrong.

broulik abandoned this revision.Jul 31 2018, 10:21 AM

Revision Contents
Changeset List

PathPackages
Mprocessui/ProcessModel.cpp (12 lines)

Diff 38789

View Options

processui/ProcessModel.cpp

Loading...