Differential D14487

[Klipper] Only create KHelpMenu when used
ClosedPublic
Actions

Authored by broulik on Jul 30 2018, 2:16 PM.

Details

Reviewers
graesslin
davidedmundson
Group Reviewers
Plasma
Commits
R120:adff6dcf7759: [Klipper] Only create KHelpMenu when used
Summary

The entry is only shown when run standalone anyway.

Test Plan

Still works when run standalone

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 30 2018, 2:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 30 2018, 2:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 30 2018, 2:16 PM
davidedmundson requested changes to this revision.Jul 30 2018, 4:07 PM
davidedmundson added a subscriber: davidedmundson.

KHelpMenu looks to lazy load internally inside KHelpMenu::menu.

What issue did this cause?

This revision now requires changes to proceed.Jul 30 2018, 4:07 PM
broulik added a comment.Jul 31 2018, 10:23 AM

What issue did this cause?

A bunch of useless QActions, createActions is called in KHelpMenu constructor. The menu itself is created lazily but the QAction instances are not

davidedmundson accepted this revision.Aug 29 2018, 12:54 PM
This revision is now accepted and ready to land.Aug 29 2018, 12:54 PM
Closed by commit R120:adff6dcf7759: [Klipper] Only create KHelpMenu when used (authored by broulik). · Explain WhyAug 29 2018, 12:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mklipper/klipperpopup.cpp (5 lines)

Diff 40641

View Options

klipper/klipperpopup.cpp

Loading...