Differential D14478

Do not leak all instances of QMLOutput when QMLScreen is destroyed
ClosedPublic
Actions

Authored by gladhorn on Jul 30 2018, 7:08 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when QMLScreen is destroyed
Summary

In practice this is most likely only a leak on exit which does not
matter, but it makes using Valgrind etc impossible.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 30 2018, 7:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 30 2018, 7:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 30 2018, 7:08 AM
davidedmundson added a subscriber: davidedmundson.Jul 30 2018, 7:58 AM
davidedmundson added inline comments.
kcm/src/declarative/qmlscreen.cpp
96

this should clear them already?

broulik added a subscriber: broulik.Jul 30 2018, 8:17 AM
broulik added inline comments.
kcm/src/declarative/qmlscreen.cpp
96

parentItem is only visual parent, it doesn't communicate ownership

romangg added a subscriber: romangg.Jul 30 2018, 10:02 AM

I also thought the call to setParentItem would clear the output. But as @broulik says it does not delete automatically. So is this good to go? Or should we make QMLScreen really a Qt Object parent of the outputs?

davidedmundson accepted this revision.Jul 30 2018, 10:05 AM

It's good to go.

This revision is now accepted and ready to land.Jul 30 2018, 10:05 AM
Closed by commit R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when QMLScreen is destroyed (authored by gladhorn). · Explain WhyJul 31 2018, 12:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38837

View Options

kcm/src/declarative/qmlscreen.h

Loading...
View Options

kcm/src/declarative/qmlscreen.cpp

Loading...