Differential D14465

Fix Move To Trash command for virtual collections
ClosedPublic
Actions

Authored by dvratil on Jul 29 2018, 5:11 PM.

Tags

Subscribers

Details

Reviewers

Commits

R206:9a4ad9a599b9: Fix Move To Trash command for virtual collections

Summary

When current folder is a virtual collection, the Items in it may belong
to multiple different resources and as such have different Trash folders.
This change makes KMTrashMsgCommand aware of this fact and to handle
this case correctly by resolving parent collections of all selected
messages.

Test Plan

Tested against the Unified Mailboxes Agent (currently loving in
dev/unified-mailboxes branch) which has virtual collections.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil created this revision.Jul 29 2018, 5:11 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 29 2018, 5:11 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.Jul 29 2018, 5:11 PM

Harbormaster completed remote builds in B1334: Diff 38715.Jul 29 2018, 5:11 PM

it seems ok. I didn't test your branch but code seems logical.

This revision is now accepted and ready to land.Jul 30 2018, 6:03 AM

Closed by commit R206:9a4ad9a599b9: Fix Move To Trash command for virtual collections (authored by dvratil). · Explain WhyJul 30 2018, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kmcommands.h (34 lines)
M			src/kmcommands.cpp (164 lines)
M			src/kmmainwidget.h (3 lines)
M			src/kmmainwidget.cpp (64 lines)

Diff 38806

src/kmcommands.h

Loading...

src/kmcommands.cpp

Loading...

src/kmmainwidget.h

Loading...

src/kmmainwidget.cpp

Loading...