Differential D14456

[effects] Put Window Aperture and eye On Screen in an exclusive category
ClosedPublic
Actions

Authored by zzag on Jul 29 2018, 1:09 PM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
KWin
Plasma
VDG
Commits
R108:c7298b24e636: [effects] Put Window Aperture and eye On Screen in an exclusive category
Summary

Having these two enabled doesn't make sense. Also, Window Aperture + eye
On Screen looks really weird.

Test Plan

Opened the Desktop Effects KCM, both the Window Aperture effect and the
eye On Screen effect are in an exclusive category:

Diff Detail

Repository
R108 KWin
Branch
effects-fix-conflict-between-window-aperture-and-eye-on-screen
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1326
Build 1344: arc lint + arc unit
zzag created this revision.Jul 29 2018, 1:09 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 29 2018, 1:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 29 2018, 1:09 PM
zzag edited the test plan for this revision. (Show Details)Jul 29 2018, 1:10 PM

What should we do about minimize effects? Move them to a separate category?

zzag retitled this revision from [effects] Put Window Aperture and eye On Screen in an exclusive group to [effects] Put Window Aperture and eye On Screen in an exclusive category.Jul 29 2018, 1:12 PM
zzag edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jul 29 2018, 1:24 PM
davidedmundson added a subscriber: davidedmundson.

What should we do about minimize effects? Move them to a separate category?

Go for it

This revision is now accepted and ready to land.Jul 29 2018, 1:24 PM
ngraham accepted this revision.Jul 29 2018, 2:08 PM
ngraham added a subscriber: ngraham.
In D14456#299988, @davidedmundson wrote:

What should we do about minimize effects? Move them to a separate category?

Go for it

+1.

Also I've never understood the "this might remind you of something" text for Eye On Screen. What is it supposed to remind me of? I don't get it.

Closed by commit R108:c7298b24e636: [effects] Put Window Aperture and eye On Screen in an exclusive category (authored by zzag). · Explain WhyJul 29 2018, 2:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38702

View Options

effects/eyeonscreen/package/metadata.desktop

Loading...
View Options

effects/windowaperture/package/metadata.desktop

Loading...