Add .arclint
ClosedPublic

Authored by zzag on Jul 27 2018, 12:39 PM.

Details

Summary

Ran arc lint --everything

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 27 2018, 12:39 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 27 2018, 12:39 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 27 2018, 12:39 PM
zzag added a comment.Jul 27 2018, 12:42 PM

The only problem I see is that the spelling linter doesn't like different languages in desktop files. E.g. it tries to correct german "plattform" word. Should we exclude desktop files?

Ran arc lint

That only checks files that have been modified. Did you add "--everything"

Is this copy pasted from somewhere else or one you've created?

zzag added a comment.EditedJul 27 2018, 12:59 PM

That only checks files that have been modified. Did you add "--everything"

Gosh, I forgot to add "--everything". Thanks.

Is this copy pasted from somewhere else or one you've created?

Based on .arclint examples and arc linters --verbose.

zzag edited the summary of this revision. (Show Details)Jul 27 2018, 12:59 PM
zzag added a comment.Jul 27 2018, 1:10 PM

The spelling linter allows to pass an optional list of dictionaries, but it looks like there is only English dictionary.

bshah accepted this revision as: bshah.Jul 30 2018, 7:12 AM
This revision is now accepted and ready to land.Jul 30 2018, 7:12 AM
romangg added a subscriber: romangg.Oct 1 2018, 5:54 PM

@zzag Do you wait for another review by @davidedmundson ?

davidedmundson accepted this revision.Oct 1 2018, 5:56 PM
zzag added a comment.Oct 1 2018, 6:29 PM

@zzag Do you wait for another review by @davidedmundson ?

Yes, I was.

This revision was automatically updated to reflect the committed changes.